Localised toml configuration file to Hindi within i18n directory #14071

avidLearnerInProgress · 2019-04-27T08:42:58Z

Added Hindi localisation for toml configuration file.
File added: https://github.com/kubernetes/website/tree/master/i18n/hi.toml

Closes #14070

k8s-ci-robot · 2019-04-27T08:43:10Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rajakavitha1

If they are not already assigned, you can assign the PR to them by writing /assign @rajakavitha1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

avidLearnerInProgress · 2019-04-27T08:43:20Z

/language hi

mittalyashu · 2019-04-27T08:51:28Z

The only possible reason for the build to fail can be because of these double-quotes.

avidLearnerInProgress · 2019-04-27T08:54:05Z

Any idea failed during stage 'building site': Build script returned non-zero exit code: 2

The only possible reason for the build to fail can be because of these double-quotes.

Check this French localisation, they too have double quotes. ->https://github.com/kubernetes/website/blob/master/i18n/fr.toml

avidLearnerInProgress · 2019-04-27T08:55:19Z

@raelga I am getting this error while deploying.
2:13:54 PM: failed during stage 'building site': Build script returned non-zero exit code: 2

Any inputs? Have I missed anything!

mittalyashu · 2019-04-27T08:56:28Z

@raelga Need some help here.

avidLearnerInProgress · 2019-04-27T09:13:50Z

Updated the commit and now I am facing below translation key issue:

2:42:23 PM: Error: "/opt/build/repo/i18n/hi.toml:1:1": failed to load translations: unable to parse translation #17 because missing "translation" key
2:42:23 PM: map[id:warning]
2:42:24 PM: Makefile:16: recipe for target 'build' failed
2:42:24 PM: make: *** [build] Error 255
2:42:24 PM: Error running command: Build script returned non-zero exit code: 2
2:42:24 PM: Failing build: Failed to build site
2:42:24 PM: failed during stage 'building site': Build script returned non-zero exit code: 2

Rajakavitha1 · 2019-04-27T12:27:42Z

/retest

Rajakavitha1

@avidLearnerInProgress just added my comment about the possible reason for the build fail.

i18n/hi.toml

raelga · 2019-04-27T18:58:28Z

Aside from the otehr typo reported in the review, you will need to add to the config.toml the new i18n localization to let hugo known about the new language:

diff --git a/config.toml b/config.toml
index d4ced34..e5a5bb5 100644
--- a/config.toml
+++ b/config.toml
@@ -248,3 +248,15 @@ contentDir = "content/id"
 time_format_blog = "02.01.2006"
 # A list of language codes to look for untranslated content, ordered from left to right.
 language_alternatives = ["en"]
+
+[languages.hi]
+title = "Kubernetes"
+description = "Production-Grade Container Orchestration"
+languageName = "हिन्दी Hindi"
+weight = 11
+contentDir = "content/hi"
+
+[languages.hi.params]
+time_format_blog = "02.01.2006"
+# A list of language codes to look for untranslated content, ordered from left to right.
+language_alternatives = ["en"]
\ No newline at end of file
diff --git a/i18n/hi.toml b/i18n/hi.toml
index 5f9fd12..48b735f 100644
--- a/i18n/hi.toml
+++ b/i18n/hi.toml
@@ -49,7 +49,7 @@ other = "सावधान:"
 other = "टिप्पणी:"

 [warning]
-otehr = "चेतावनी:"
+other = "चेतावनी:"

 [main_read_about]
 other = "के बारे में पढ़ें"

With that configuration compiles as expected:

rael@W001062:website (docs-hi)
$ make serve
hugo server --buildFuture

                   |  EN  | ZH  | KO  | JA  | FR  | IT  | DE  | ES  | PT  | ID  | HI
+------------------+------+-----+-----+-----+-----+-----+-----+-----+-----+-----+-----+
  Pages            | 1012 | 201 | 190 |  71 |  65 |  34 |  86 |  97 |  12 |  13 |   5
  Paginator pages  |  278 |   5 |   0 |   0 |   0 |   0 |   0 |   0 |   0 |   0 |   0
  Non-page files   |  465 | 130 | 132 | 203 |  32 |  17 | 122 | 142 |  10 |  10 |   0
  Static files     |  883 | 883 | 883 | 883 | 883 | 883 | 883 | 883 | 883 | 883 | 883
  Processed images |    0 |   0 |   0 |   0 |   0 |   0 |   0 |   0 |   0 |   0 |   0
  Aliases          |    5 |   1 |   0 |   0 |   0 |   1 |   1 |   1 |   1 |   0 |   0
  Sitemaps         |    2 |   1 |   1 |   1 |   1 |   1 |   1 |   1 |   1 |   1 |   1
  Cleaned          |    0 |   0 |   0 |   0 |   0 |   0 |   0 |   0 |   0 |   0 |   0

Total in 52787 ms
Watching for changes in /c/Users/rgarcia/Code/gh/avd/website/{content,data,i18n,layouts,static}
Watching for config changes in /c/Users/rgarcia/Code/gh/avd/website/config.toml
Environment: "development"
Serving pages from memory
Running in Fast Render Mode. For full rebuilds on change: hugo server --disableFastRender
Web Server is available at http://localhost:1313/ (bind address 127.0.0.1)
Press Ctrl+C to stop

netlify · 2019-04-28T02:35:05Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 6f4e795

https://deploy-preview-14071--kubernetes-io-master-staging.netlify.com

avidLearnerInProgress · 2019-04-28T02:40:50Z

@Rajakavitha1 @mittalyashu @daminisatya please proceed with the peer reviews for this one.

mittalyashu · 2019-04-28T03:28:46Z

I think it will take months before we can merge this PR since most of the localizing is missing or need to be done.

🤔

Rajakavitha1

This looks good to me. You don't have to incorporate all of my suggestions.

@mittalyashu and @daminisatya please chime in.

Rajakavitha1 · 2019-04-28T03:17:28Z

i18n/hi.toml

+other = "पदावनत" 
+
+[objectives_heading]
+other = "उद्देश्य"


may be: उद्देश्यों

Rajakavitha1 · 2019-04-28T03:31:12Z

i18n/hi.toml

+other = "आपका कुबरनेट्स सर्वर संस्करण की तुलना में या बाद में होना चाहिए  "
+
+[version_check_tocheck]
+other = "संस्करण की जांच करने के लिए, प्रवेश करें  "


प्रवेश करें or enter करें ?

I would go with प्रवेश करें.

Rajakavitha1 · 2019-04-28T03:32:25Z

i18n/hi.toml

+other = "के बारे में पढ़ें"
+
+[main_read_more]
+other = "और पढ़ें"


may be: अधिक पढ़ें

mittalyashu · 2019-04-28T04:46:58Z

i18n/hi.toml

+# i18n strings for the Hindi site.
+
+[deprecation_warning]
+other = "प्रलेखन अब सक्रिय रूप से बनाए नहीं रखा गया है। वर्तमान में आप जिस संस्करण को देख रहे हैं वह एक स्थिर स्नैपशॉट है। अप-टू-डेट प्रलेखन के लिए, देखें | "


प्रलेखन पर अब सक्रिय रूप से काम नहीं किया जा रहा है।

Can someone suggest a better word for संस्करण?

Can you remove | from the end?

mittalyashu · 2019-04-28T04:58:39Z

i18n/hi.toml

+other = "प्रतिक्रिया"
+
+[feedback_question]
+other = "क्या यह पृष्ठ उपयोगी था?"


पृष्ठ is kind of a big word, we can use a simple word like, पेज

mittalyashu · 2019-04-28T05:02:23Z

i18n/hi.toml

+other = "और पढ़ें"
+
+[main_github_invite]
+other = "कोर कुबरनेट्स कोड आधार पर हैकिंग में रुचि रखते हैं?"


I am finding it difficult to understand this sentence "Interested in hacking on the core Kubernetes code base?"

Since this is not matching up कोर कुबरनेट्स कोड

mittalyashu · 2019-04-28T05:06:00Z

i18n/hi.toml

+other = "GitHub पर देखें"
+
+[main_github_create_an_issue]
+other = "एक मुद्दा बनाएँ"


मुद्दा is not a bad choice, but I think it is mainly used in discussion or in public talks, while मसला is related to a specific problem.

mittalyashu · 2019-04-28T05:09:29Z

i18n/hi.toml

+other = "एक मुद्दा बनाएँ"
+
+[main_community_explore]
+other = "समुदाय का अन्वेषण करें"


How about समुदाय का दौर करें?

I know this is not the best word of choice. Just exploring different words we can use.

mittalyashu · 2019-04-28T05:10:47Z

i18n/hi.toml

+other = "समुदाय का अन्वेषण करें"
+
+[main_kubernetes_features]
+other = "कुबरनेट्स विशेषताएं"


The features of Kubernetes, कुबरनेट्स की विशेषताएं

कुबरनेट्स की विशेषताएं tells that we are referring to the features of kubernets.

k8s-ci-robot · 2019-05-13T18:56:52Z

@avidLearnerInProgress: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

raelga · 2019-05-30T17:28:47Z

Until the conflict is fixed, is better to hold this PR.

@mittalyashu let me know if I can can help with the rebase! 💙

/hold

mittalyashu · 2019-07-02T09:03:16Z

There are still few lines left to review.

mittalyashu · 2019-07-27T15:17:30Z

I will re-review the whole PR again and update you on that further.

raelga · 2019-10-05T10:20:56Z

@mittalyashu @avidLearnerInProgress let me know if you need any help with the rebase :)

fejta-bot · 2020-01-03T11:14:57Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2020-02-02T11:56:56Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

kbhawkey · 2020-02-08T19:54:29Z

@avidLearnerInProgress @mittalyashu @Rajakavitha1 @raelga ,
What is the status of this PR? I plan to close this PR due to inactivity.

kbhawkey · 2020-02-19T19:06:19Z

/close

k8s-ci-robot · 2020-02-19T19:06:21Z

@kbhawkey: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Added hi.toml-in-i18n

f62fe8a

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 27, 2019

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 27, 2019

k8s-ci-robot requested review from Rajakavitha1 and stewart-yu April 27, 2019 08:43

k8s-ci-robot added the language/hi Issues or PRs related to Hindi language label Apr 27, 2019

avidLearnerInProgress changed the title ~~Localised toml configuration file to Hindi within i18n~~ Localised toml configuration file to Hindi within i18n directory Apr 27, 2019

Updated i18n/hi.toml file

4fc1196

Rajakavitha1 reviewed Apr 27, 2019

View reviewed changes

i18n/hi.toml Outdated Show resolved Hide resolved

avidLearnerInProgress added 2 commits April 27, 2019 20:37

Updated i18n/hi.toml file

1d566e5

Updated i18n/hi.toml file

08d0443

raelga reviewed Apr 27, 2019

View reviewed changes

i18n/hi.toml Outdated Show resolved Hide resolved

avidLearnerInProgress added 2 commits April 28, 2019 00:30

Updated i18n/hi.toml file

fec51c6

Updated-toml-and-config-file

6f4e795

k8s-ci-robot assigned avidLearnerInProgress Apr 28, 2019

Rajakavitha1 reviewed Apr 28, 2019

View reviewed changes

mittalyashu reviewed Apr 28, 2019

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2019

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2019

avidLearnerInProgress mentioned this pull request Jul 27, 2019

Localise toml configuration file in i18n to Hindi #14070

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2020

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 2, 2020

k8s-ci-robot closed this Feb 19, 2020

Localised toml configuration file to Hindi within i18n directory #14071

Localised toml configuration file to Hindi within i18n directory #14071

Conversation

avidLearnerInProgress commented Apr 27, 2019 • edited by mittalyashu Loading

k8s-ci-robot commented Apr 27, 2019

avidLearnerInProgress commented Apr 27, 2019 • edited Loading

mittalyashu commented Apr 27, 2019

avidLearnerInProgress commented Apr 27, 2019

avidLearnerInProgress commented Apr 27, 2019

mittalyashu commented Apr 27, 2019

avidLearnerInProgress commented Apr 27, 2019 • edited Loading

Rajakavitha1 commented Apr 27, 2019

Rajakavitha1 left a comment

Choose a reason for hiding this comment

raelga commented Apr 27, 2019 • edited Loading

netlify bot commented Apr 28, 2019

avidLearnerInProgress commented Apr 28, 2019 • edited Loading

mittalyashu commented Apr 28, 2019

Rajakavitha1 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented May 13, 2019

raelga commented May 30, 2019

mittalyashu commented Jul 2, 2019

mittalyashu commented Jul 27, 2019

raelga commented Oct 5, 2019

fejta-bot commented Jan 3, 2020

fejta-bot commented Feb 2, 2020

kbhawkey commented Feb 8, 2020

kbhawkey commented Feb 19, 2020

k8s-ci-robot commented Feb 19, 2020

avidLearnerInProgress commented Apr 27, 2019 •

edited by mittalyashu

Loading

avidLearnerInProgress commented Apr 27, 2019 •

edited

Loading

avidLearnerInProgress commented Apr 27, 2019 •

edited

Loading

raelga commented Apr 27, 2019 •

edited

Loading

avidLearnerInProgress commented Apr 28, 2019 •

edited

Loading

Rajakavitha1 left a comment •

edited

Loading